Re: [Xen-devel] [PATCH v2] tools: Improve make deb

[Alex Bligh <alex@xxxxxxxxxxx>]

--On 26 February 2013 13:09:18 +0000 Ian Campbell <Ian.Campbell@xxxxxxxxxx> 
wrote:
> On Tue, 2013-02-26 at 12:58 +0000, Stefano Stabellini wrote:
> > > +cat >deb/DEBIAN/postrm <<EOF
> > > +#!/bin/bash -e
> > > +insserv -r xendomains &&
> > > +insserv -r xencommons
> [...]
> > All the changes look good to me
> This one certainly isn't, calling insserv directly in a pre/post inst is
> not the correct Debian interface to use.
>
> Better to call update-rc.d I think, or use dh_installinit (and grow a
> build time dependency on debhelper).
Or better yet, put a .init file in your debian directory and use the
normal dh_tools to do it.

--
Alex Bligh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel