Re: [Xen-devel] [PATCH v2] tools: Improve make deb

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

fantonifabio@xxxxxxxxxx writes ("[Xen-devel] [PATCH v2] tools: Improve make 
deb"):
> Changes from v1:
> - Added on description that this make a build for testing only.
> - Improved add/remove of main service.

I'm not convinced that this is a good idea.

Firstly, the point of the "make deb" target is not to provide a
proper, fully featured, Debian binary package.  That work should be
done in Debian.

The point of our `make deb' is to provide a simple way for people
using Debian-derived systems to get the bits onto their disk and
remove them again afterwards.

> diff --git a/tools/misc/mkdeb b/tools/misc/mkdeb
> index 2e40747..fe7e1b1 100644
> --- a/tools/misc/mkdeb
> +++ b/tools/misc/mkdeb
> @@ -33,7 +33,7 @@ fi
>  # Fill in the debian boilerplate
>  mkdir -p deb/DEBIAN
>  cat >deb/DEBIAN/control <<EOF
> -Package: xen-upstream-$version
> +Package: xen-upstream

I don't object to this change because they're not coinstallable
anyway.

> +cat >deb/DEBIAN/conffiles <<EOF
> +/etc/xen/xl.conf
> +/etc/xen/xend-config.sxp
> +/etc/default/xendomains
> +/etc/default/xencommons
> +EOF

This is fine too IMO but it should be done with
"find -type f" rather than listing these files explicitly.

> +cat >deb/DEBIAN/postinst <<EOF
> +#!/bin/bash -e
> +insserv xencommons &&
> +insserv xendomains
> +EOF
> +cat >deb/DEBIAN/postrm <<EOF
> +#!/bin/bash -e
> +insserv -r xendomains &&
> +insserv -r xencommons
>  EOF

I do object to these.  "Getting the bits onto your system" doesn't
include automatically starting the daemons.

(Others have pointed out that this isn't the way to do it, anyway.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel