Re: [Xen-devel] [PATCH V3] vmx/nmi: Do not use self_nmi() in VMEXIT handler

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.02.13 at 15:49, Tim Deegan <tim@xxxxxxx> wrote:
> At 14:42 +0000 on 28 Feb (1362062542), Jan Beulich wrote:
>> Checking for this
>> here would be strait forward, but I was really considering to do
>> all of this in the assembly exit path, and I was still undecided
>> whether we shouldn't follow Linux in skipping softirq processing
>> (and hence scheduling) on the way out from an NMI (I don't
>> think we'd need to do the same for MCE).
> 
> That sounds sensible, if it simplifies the logic (i.e. if it avoids
> needing an extra IRET just to re-enable NMIs when we might as well IRET
> to the guest).  Or is there any other reason to avoid it?

No, I don't think so. We only need to make sure we don't execute
one as long as we're on the NMI stack.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel