Re: [Xen-devel] [PATCH V2 21/33] xen/arm: Use device tree API in pl011 UART driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 17:23 +0100, Julien Grall wrote:
> > That does then call into question the whole serial_arm_defaults thing.
> > Perhaps index should just be the order in which they are registered (and
> > at the moment it is effectively hardcoded to 0 anyway)
> 
> 
> I'm thinking about using serial_arm_defaults for baud rate,... For the
> moment the different values are hardcoded.
> 
> {arm,dt}_init_uart will parse the dtuart parameters on the command line
> and then fill serial_arm_defaults.

Perhaps instead of &serial_arm_defaults you should pass a char * pointer
to opt_dtuart? This would allow for per-device settings and is
consistent with the ns16550 driver.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel