[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 21/33] xen/arm: Use device tree API in pl011 UART driver

On 05/08/2013 05:43 PM, Ian Campbell wrote:

> On Wed, 2013-05-08 at 17:23 +0100, Julien Grall wrote:
>>> That does then call into question the whole serial_arm_defaults thing.
>>> Perhaps index should just be the order in which they are registered (and
>>> at the moment it is effectively hardcoded to 0 anyway)
>> I'm thinking about using serial_arm_defaults for baud rate,... For the
>> moment the different values are hardcoded.
>> {arm,dt}_init_uart will parse the dtuart parameters on the command line
>> and then fill serial_arm_defaults.
> Perhaps instead of &serial_arm_defaults you should pass a char * pointer
> to opt_dtuart? This would allow for per-device settings and is
> consistent with the ns16550 driver.

Ok. I will modify it in the next patch series.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.