Re: [Xen-devel] [PATCH 2/3] libxl: Change claim_mode from bool to int.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-05-09 at 14:23 +0100, Konrad Rzeszutek Wilk wrote:

> > >  
> > >      if (!libxl_get_freecpus(ctx, &cpumap)) {
> > > @@ -5911,7 +5911,7 @@ int main_claims(int argc, char **argv)
> > >          /* No options */
> > >      }
> > >  
> > > -    if (!libxl_defbool_val(claim_mode))
> > > +    if (!claim_mode)
> > >          fprintf(stderr, "claim_mode not enabled (see man xl.conf).\n");
> > 
> > You don't exit here? Like above I think it would be actually OK for it
> > to just list the domains with claims of zero.
> 
> Ian Jackson during the review suggested that it just print that warning
> and continue on. And now that I am using I actually like the warning. It
> reminds me that I forgot to enable or disable it.

OK.

> > 
> > FWIW It occurs to me now that this could have just been "xl list
> > --claims/-c", but it's there now.
> 
> I can certainly try to redo it. I think I tried it two weeks ago and ran
> in the trouble of having to modify a bunch of extra print_* functions to
> have the extra claim information. And also not being sure how to expose
> it via the JSON or sxp.

Not sure what you mean, main_claims just calls list_domains with
claims==1, so main_list could call it with claims == some flag set by a
command line option.

WRT sxp -- you don't need to care, that is purely legacy and shouldn't
be updated with new features .

Not sure which JSON exposes this, but you should get the field for free
due to using the IDL for this stuff

> I can certainly rework this for Xen 4.4 ? Or for Xen 4.3 if you think
> that George would be OK with that.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel