[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/18] PVH xen: add XENMEM_add_to_physmap_range



On Wed, 05 Jun 2013 08:32:52 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 05.06.13 at 02:31, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> >> I also vaguely recall having pointed out in a much earlier review
> >> that this functionality is lacking a counterpart in
> >> compat_arch_memory_op().
> > 
> > Hmm.. confused how/why a 64bit PVH go thru compat_arch_memory_op()?
> > Can you pl explain?
> 
> Iirc the new hypercall isn't restricted to PVH guests, and hence
> needs a compat implementation regardless of 32-bit PVH not
> existing yet.

This patch does not introduce the hcall, it was introduced much earlier.
It implements the portion needed for 64bit PVH. It also documents the 
intention in the public header file for the subcall it uses:

#define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom,
                                    * XENMEM_add_to_physmap_range only.
                                    * (PVH x86 only) */

thanks,
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.