[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2 v3] iommu/amd: Fix logic for clearing the IOMMU interrupt bits

On 6/10/2013 7:31 AM, Jan Beulich wrote:
@@ -439,8 +439,8 @@ static void iommu_reset_log(struct amd_i
>> >> ctrl_func(iommu, IOMMU_CONTROL_DISABLED); >> >>- /*clear overflow bit */
>>-    iommu_clear_bit(&entry, of_bit);
>>+    /* RW1C overflow bit */
>>+    iommu_set_bit(&entry, of_bit);
>>      writel(entry, iommu->mmio_base + IOMMU_STATUS_MMIO_OFFSET);
>Won't this clear all other status bits as well?
Yes it will, albeit not because of this patch. But I guess we should
fix this as we go. Expect v4 soon...
Sorry, I missed one case.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.