[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/misc/xencov.c: Use MAP_WIRED on NetBSD

On 12/06/13 13:14, Ian Campbell wrote:
On Wed, 2013-06-12 at 13:02 +0100, Frediano Ziglio wrote:
Subject: [PATCH] gcov: Do not use mmap directly but use 

xencov.c did not compile on NetBSD so use xc_hypercall_buffer which is
more portable.

Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
Looks good to me, thanks,

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

George, what is your feeling for the release? This is a somewhat obscure
tool and IMHO the risk of regressing is small. The change fixes the
default build on NetBSD.

Did we even have gcov in 4.2? Anyway I agree, the benefits are worth more than the risk.

Re the release:
Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.