Re: [Xen-devel] [PATCH] tools/misc/xencov.c: Use MAP_WIRED on NetBSD

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-06-12 at 14:13 +0100, George Dunlap wrote:
> On 12/06/13 13:14, Ian Campbell wrote:
> > On Wed, 2013-06-12 at 13:02 +0100, Frediano Ziglio wrote:
> >> Subject: [PATCH] gcov: Do not use mmap directly but use 
> >> xc_hypercall_buffer_alloc
> >>
> >> xencov.c did not compile on NetBSD so use xc_hypercall_buffer which is
> >> more portable.
> >>
> >> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
> > Looks good to me, thanks,
> >
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> > George, what is your feeling for the release? This is a somewhat obscure
> > tool and IMHO the risk of regressing is small. The change fixes the
> > default build on NetBSD.
> 
> Did we even have gcov in 4.2?

Good point, no we didn't.

>   Anyway I agree, the benefits are worth 
> more than the risk.
> 
> Re the release:
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
>   -George
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel