Re: [Xen-devel] [PATCH] Add a device_model_machine option for HVM domains to libxl.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-06-18 at 20:06 +0100, Stefano Stabellini wrote:
> On Mon, 17 Jun 2013, Paul Durrant wrote:
> > The device-model machine type used for HVM domains is currently hardcoded to
> > 'xenfv'. This patch adds a device_model_machine option, which defaults to
> > 'xenfv' for comatibility, but allows the specification of an alternative
> > machine type 'pc'.
> > Note that use of the 'pc' machine type relies on patches that I have
> > submitted to qemu-devel.
> > 
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> NACK
> 
> I don't think that this kind of option should exposed to the user except
> maybe for debugging purposed.
> We need a way to automatically select the right one.

I think ultimately we will need some sort of option like this to support
evolving the virtualised platform, i.e. when we want to introduce for
more modern systems (e.g. Q35 based with PCIe support).

I didn't review in details since obviously there is a higher level
discussion to have first, but I did spot:

> +        b_info->u.hvm.machine = LIBXL_DEVICE_MODEL_HVM_MACHINE_DEFAULT;

This isn't needed, libxl_domain_build_info_init() will DTRT here.

Ian,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel