[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv6 0/10] kexec: extend kexec hypercall for use with pv-ops kernels

On Mon, Jun 24, 2013 at 06:42:11PM +0100, David Vrabel wrote:


> Changes since v4 (v5 was not posted to the list):
> - _rsvd -> _pad in one of the public ABI structures.
> - Fix bug where trailing pages were not zeroed. This fixes loading a
>   64-bit Linux kernel using a more recent version of kexec-tools.

Why? I do not see why trailing pages must be zeroed. I am afraid that
this way you are only masking bug in kexec-tools. I think it is better
to do bisect on it and find out which patch introduces a bug.

In general this series is OK but as I can see Jan has some comments
this time. I think that it is worth to take most of them into account.

Please prepare next version of these patches and repost with
kexec-tools patches. They are integral part of new Xen kexec
implementation and it is worth to review both patch series together.


PS I will be on holiday next week and I would not be able to do reviews.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.