[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Xendomains was not correctly suspending domains when a STOP was issued.


  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • From: Ian Murray <murrayie@xxxxxxxxxxx>
  • Date: Thu, 27 Jun 2013 13:15:33 +0100 (BST)
  • Cc: "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 27 Jun 2013 12:15:52 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.co.uk; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=6W22KGZ1jJYYFxXK1hT7R/KzLRMbqnivKgZBnE7sVZWnDSrFQw2zzmcdQjtg60FKNFMzPzodpsWR6mZTMnGuEJOglCuR1dljPyRsWTW0Jtr33kkVl1X+hNJAo2ryYPRUEdTPIZmWsLRSlazoI4V3lgrnuTmptU4FQEp6SCePeE0=;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>




----- Original Message -----
> From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> To: Ian Murray <murrayie@xxxxxxxxxxx>
> Cc: "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
> Sent: Thursday, 27 June 2013, 12:59
> Subject: Re: [Xen-devel] [PATCH] Xendomains was not correctly suspending
 domains when a STOP was issued.
> 
> On Thu, 2013-06-27 at 12:51 +0100, Ian Murray wrote:
>>  Thanks. BTW, the JSON output of 4.3 looked the same to me as 4.2.2
>>  (i.e. badly formed), so I am not sure the patch you mentioned to make
>>  it well-formed was in as of 4.3 RC5.  if/when the well formed patch is
>>  introduced (if it isn't already), it may very well break this
>>  (xendomains) patch.
> 
> Looks like I was mistaken and that fix was already in 4.2.0 (rc4 to be
> precise).

Yeah, according to http://jsonlint.com/ the output is valid. I thought it 
needed a left-hand object name to be valid, but it seems I was wrong. Anyway, 
it'is all good.

Thanks.

p.s. Looks like this patch missed RC6 by 40 minutes. :(

.


> 
> commit ac963eb7895b8351017bb6005505c2b176202f0e
> Author: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date:   Thu Aug 23 19:12:28 2012 +0100
> 
>     xl: make "xl list -l" proper JSON
>     
>     Bastian Blank reports that the output of this command is just multiple
>     JSON objects concatenated and is not a single properly formed JSON
>     object.
>     
>     Fix this by wrapping in an array. This turned out to be a bit more
>     intrusive than I was expecting due to the requirement to keep
>     supporting the SXP output mode.
>     
>     Python's json module is happy to parse the result...
>     
>     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.