Re: [Xen-devel] [PATCH v2] introduce a cache options for PV disks

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-06-27 at 17:34 +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH v2] introduce a cache options for PV disks"):
> > Ian Campbell writes ("Re: [PATCH v2] introduce a cache options for PV 
> > disks"):
> > > On Thu, 2013-06-27 at 17:09 +0100, Ian Jackson wrote:
> > > > + *      So use of O_DIRECT is safe, in circumstances
> > > 
> > >            ^Some ?
> > > 
> > > Otherwise I can't parse this sentence.
> > 
> > Yes.
> 
> In, fact, no.  How about:
> 
>  *      That is, if this option is enabled, use of O_DIRECT is safe,
>  *      in circumstances where we would normally have avoided it as a
>  *      workaround for that bug.  This option is not relevant for ...

I think I can parse it now. It doesn't really say what the option does
though. I'd expect it to say something about "disabling the workaround"
or "the backend may use O_DIRECT".

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel