[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/5] time: indicate that the clock was set in the pvclock gtod notifier chain

On 06/27/2013 03:35 AM, David Vrabel wrote:
From: David Vrabel <david.vrabel@xxxxxxxxxx>

If the clock was set (stepped), set the action parameter to functions
in the pvclock gtod notifier chain to non-zero.  This allows the
callee to only do work if the clock was stepped.

This will be used on Xen as the synchronization of the Xen wallclock
to the control domain's (dom0) system time will be done with this
notifier and updating on every timer tick is unnecessary and too

Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

Looks pretty good. Minor note below.

@@ -1239,9 +1240,10 @@ out_adjust:
   * It also calls into the NTP code to handle leapsecond processing.
-static inline void accumulate_nsecs_to_secs(struct timekeeper *tk)
+static inline bool accumulate_nsecs_to_secs(struct timekeeper *tk)
Shouldn't this be unsigned instead of bool?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.