Re: [Xen-devel] [PATCH] docs: Correct docs for extra_guest_irqs command line option

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-07-31 at 09:49 +0100, Ian Campbell wrote:
> On Tue, 2013-07-30 at 19:59 +0100, Andrew Cooper wrote:
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > ---
> >  docs/misc/xen-command-line.markdown |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/docs/misc/xen-command-line.markdown 
> > b/docs/misc/xen-command-line.markdown
> > index 708ffc2..9af8901 100644
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -485,9 +485,13 @@ disable it (edid=no). This option should not normally 
> > be required
> >  except for debugging purposes.
> >  
> >  ### extra\_guest\_irqs
> > -> `= <number>`
> > +> `= [<domU number>][,<dom0 number>]`
> >  
> > -Increase the number of PIRQs available for the guest. The default is 32. 
> > +> Default: `32,256`
> > +
> > +Change the number of PIRQs available for guests.  The optional first 
> > number is
> > +common for all domUs, while the optional second number (preceeded by a 
> > comma)
> 
>                                                           preceded
> 
> With that fixed:
> Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

Actually, it's not 100% clear to me if you only give a single number
whether that also applies to dom0 or not I assume it would, but I'm not
sure and the docs say domU explicitly twice. Do you think you could
reword it to make it obvious? Perhaps = [<number>][,<dom0 override>] ?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel