Re: [Xen-devel] Spurious Acks (was Re: PVH domU patches....)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-08-06 at 11:00 +0100, George Dunlap wrote:
> On Mon, Aug 5, 2013 at 10:18 PM, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> 
> wrote:
> > On Thu, 1 Aug 2013 11:21:33 +0100
> > Tim Deegan <tim@xxxxxxx> wrote:
> >
> >> Hi,
> >>
> >> At 14:43 -0700 on 31 Jul (1375281803), Mukesh Rathor wrote:
> >> > The latest tree with Tim's acks are at:
> >> >
> >> >    git clone git://oss.oracle.com/git/mrathor/xen.git .
> >> >    git checkout pvh.v10.acked-1
> >>
> >> This branch has my Reviewed-by: on
> >> 1f2087845751569fc55c202ac3265e18c974b0bf (PVH xen: vmcs related
> >> changes), which I don't remember giving. Please be careful about that
> >> sort of thing.
> >>
> >> There have been a few instances in the past of patches that went in on
> >> someone else's ack that seem to have sprouted mine (not from Mukesh, I
> >> should add, and AFAICT through misunderstanding rather than malice).
> >> In future I am going to revert such patches when I notice them.
> >>
> >> Cheers,
> >>
> >> Tim.
> >
> >
> > Ok, I misunderstood whey you said the code looked OK, I assumed it was
> > an implicit ack, as I've seen here in the past. I'll make a note, Tim
> > doesn't give implicit acks... :)...
> >
> > I'll remove your ack.
> 
> I'm pretty sure no one gives implicit Acks.  Saying the code looks OK
> is just that -- it says the code looks OK, not that the person is OK
> with the code going in, and absolutely not everything that
> "Reviewed-by" means (which is a lot more than an Ack).

There are some maintainers who say something informal but when asked
"can I take that as an ack" say yes, which eventually leads to laziness
on the part of submitters (and indeed committers) who get bored of
asking the clarify question. It doesn't seem to be happening as much as
it once was though.

I think people, and maintainers in particular, need to get in the habit
of spelling the ack or review-by out explicitly, because ambiguity does
lead to confusion here.

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel