Re: [Xen-devel] [PATCH v5 2/5] xen/arm: add 8250 compatible UART support for early_printk

[Chen Baozi <baozich@xxxxxxxxx>]

On Aug 8, 2013, at 7:36 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> On Thu, 2013-08-08 at 12:34 +0100, Ian Campbell wrote:
> 
>>> diff --git a/xen/include/xen/8250-uart.h b/xen/include/xen/8250-uart.h
>>> index 7287364..33daa6d 100644
>>> --- a/xen/include/xen/8250-uart.h
>>> +++ b/xen/include/xen/8250-uart.h
>>> @@ -22,6 +22,10 @@
>>> #ifndef __XEN_8250_UART_H__
>>> #define __XEN_8250_UART_H__
>>> 
>>> +#ifdef CONFIG_ARM
>>> +#define REG_SHIFT         2
>>> +#endif
>> 
>> I think this should actually be part of the per-platform early-printk
>> block, e.g. EARLY_UART_REG_SHIFT
> 
> I should have also said that for non-early drivers this should come from
> the device tree.
> 
> Possibly in the case of your OMAP speciifc driver it could be hardcoded,
> but only if it isn't in DT IMHO.

It seems OMAP5's DT doesn't have this info? Does exynos5 have it?

Baozi

> 
> Ian.
> 
>> 
>>> +
>>> /* Register offsets */
>>> #define UART_RBR          0x00    /* receive buffer       */
>>> #define UART_THR          0x00    /* transmit holding     */
>> 
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel