Re: [Xen-devel] [PATCH v2 0/6] Nested VMX: APIC-v related bug fixing

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> 08/19/13 5:13 AM >>>
>Jan Beulich wrote on 2013-08-16:
>>>>> On 16.08.13 at 07:43, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>>> Changes from v1:
>>> * rebase on top of Xen.
>>> * Minor adjustment according the comments.
>> 
>> Many of the comments I made on v1 still apply. I'm not going to repeat them.
>Sorry, I forget to CC the maintainer. Except this, I don't see any other 
>missing comments. Please point out them if I am missing. Thanks.

The main fact being the break up of the patches, with (iirc) 1 and 3 
introducing things
not needed until a later (and not even immediately subsequent) patch. As said 
before -
such break up is desirable when a truly huge patch otherwise becomes 
unreviewable,
but that doesn't appear to be the case here. In your consideration here you 
need to -
namely when fixing bugs - include the aspect of backporting: Needing to pull in
prerequisite patches that aren't obviously prerequisites causes extra 
attention/work.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel