Re: [Xen-devel] [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2013-09-18 at 18:06 +0100, Julien Grall wrote:
> On 09/17/2013 02:40 AM, Ian Campbell wrote:
> 
> > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> > index b8334e2..abaacfd 100644
> > --- a/xen/arch/arm/arm32/head.S
> > +++ b/xen/arch/arm/arm32/head.S
> > @@ -37,6 +37,25 @@
> 
> [..]
> 
> > +
> > +common_start:
> > +        mov   r7, #0                 /* r13 := CPU ID */
> > +        mrc   CP32(r1, MPIDR)
> > +        tst   r1, #(1<<31)           /* Multiprocessor extension 
> > supported? */
> > +        beq   1f
> > +        tst   r1, #(1<<30)           /* Uniprocessor system? */
> > +        bne   1f
> > +        bic   r7, r1, #(0xff << 24)  /* Mask out flags to get CPU ID */
> 
> Can you use #(~MPIDR_HWID_MASK) instead of #(0xff << 24)?
> I think, it's the same in arm64/head.S.

Yes, I've got that change locally already.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel