Re: [Xen-devel] [PATCH RFC 4/7] xen: arm: add two new device tree helpers

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2013-09-18 at 18:11 +0100, Julien Grall wrote:
> On 09/17/2013 02:40 AM, Ian Campbell wrote:
> >  - dt_property_read_u64
> >  - dt_find_node_by_type
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> >  xen/common/device_tree.c      | 29 +++++++++++++++++++++++++++++
> >  xen/include/xen/device_tree.h | 16 ++++++++++++++++
> >  2 files changed, 45 insertions(+)
> > 
> > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> > index 3a3c99c..74a82bc 100644
> > --- a/xen/common/device_tree.c
> > +++ b/xen/common/device_tree.c
> > @@ -589,6 +589,21 @@ bool_t dt_property_read_u32(const struct 
> > dt_device_node *np,
> >      return 1;
> >  }
> >  
> > +bool_t dt_property_read_u64(const struct dt_device_node *np,
> > +                         const char *name, u64 *out_value)
> > +{
> > +    u32 len;
> > +    const __be32 *val;
> > +
> > +    val = dt_get_property(np, name, &len);
> > +    if ( !val || len < sizeof(*out_value) )
> > +        return 0;
> > +
> > +    *out_value = dt_read_number(val, 2);
> > +
> > +    return 1;
> > +}
> > +
> >  bool_t dt_device_is_compatible(const struct dt_device_node *device,
> >                                 const char *compat)
> >  {
> > @@ -637,6 +652,20 @@ struct dt_device_node *dt_find_node_by_name(struct 
> > dt_device_node *from,
> >      return np;
> >  }
> >  
> > +struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from,
> > +                                            const char *type)
> > +{
> > +    struct dt_device_node *np;
> > +    struct dt_device_node *dt;
> > +
> > +    dt = from ? from->allnext : dt_host;
> > +    for_each_device_node(dt, np)
> 
> Minor mistake, for_each_device_node was renamed to
> dt_for_each_device_node in the current xen tree.

Ack, I caught this while rebasing too, thanks though.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel