Re: [Xen-devel] [PATCH v2 06/13] x86/PMU: Add public xenpmu.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.09.13 at 17:59, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 09/25/2013 10:04 AM, Jan Beulich wrote
>>> --- /dev/null
>>> +++ b/xen/include/public/xenpmu.h
>>> @@ -0,0 +1,38 @@
>>> +#ifndef __XEN_PUBLIC_XENPMU_H__
>>> +#define __XEN_PUBLIC_XENPMU_H__
>>> +
>>> +#include "xen.h"
>>> +#if defined(__i386__) || defined(__x86_64__)
>>> +#include "arch-x86/xenpmu-x86.h"
>>> +#elif defined (__arm__) || defined (__aarch64__)
>>> +#include "arch-arm.h"
>> ???
> 
> 
> I need to define arch_xenpmu_t in all architectures.

Right, but why not arch-arm/xenpmu-arm.h? (And maybe you
could stick a few more arms here and there - read: why the x86
duplication in the x86 name?)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel