[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] oxenstored to allow updates regardless of quota

On Thu, 2013-10-31 at 16:32 +0000, Thomas Sanders wrote:
> Here I'm submitting to xen-devel a patch written by Zheng Li.

If you "git commit --author='Zheng Li <...@xxxxxxxxxx>'" and then use
git send-email it will do the right thing which is $subject "CA-108294:
allow a domain ..." and then a pseudoheader in the body:
  From: Zheng Li <...@xxxxxxxxxx>

  <commit message>

  S-o-b: ...

The git tools then consume this on my end and DTRT. It also removes the
need for you to write a little preamble explaining who wrote the patch.

BTW, a shorter subject, omitting the CA-xxx and including a oxenstored:
prefix would be appreciated too.

I can do all this as I commit but it seems like you might be sending
more such patches in the future so thought I'd bring it up ;-)

> Thomas Sanders
> CA-108294: allow a domain updating existing xenstore keys even if it
> has already reached its max entries limit
> As updating existing key won't increase the number of entries
> belonging to a domain, we should avoid checking the max entries limit
> prematurely. The patch addresses this issue in the following
> functions: write/add, mkdir, setperms. 
> Signed-off-by: Zheng Li <zheng.li@xxxxxxxxxxxxx>

The patch looks good to me, in so far as I speak ocaml so:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

But I'd much prefer to have Dave's ACK too.

I think it would be appropriate (but not mandatory) for you to either
Signed-off-by, Acked-by or Reviewed-by the patch yourself since you have
forwarded it on. For forms sake and per the DCO an S-o-b should probably
be added.

> +     (* It's upt to the mkdir logic to decide what to do with existing path 
> *)

typo. I can fix on commit, assuming I remember.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.