[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] oxenstored to allow updates regardless of quota

On 01 November 2013 at 4:19 PM, Ian Campbell wrote:
> If you [issue certain git commands]
> The git tools then consume this on my end and DTRT. It also removes the
> need for you to write a little preamble explaining who wrote the patch.
> BTW, a shorter subject, omitting the CA-xxx and including a oxenstored:
> prefix would be appreciated too.
> I can do all this as I commit but it seems like you might be sending
> more such patches in the future so thought I'd bring it up ;-)

Thank you. That's all useful. I'll bear it in mind in future.

> The patch looks good to me, in so far as I speak ocaml so:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> But I'd much prefer to have Dave's ACK too.

Makes sense. This morning he told me, "I'll reply in a bit."

> I think it would be appropriate (but not mandatory) for you to either
> Signed-off-by, Acked-by or Reviewed-by the patch yourself since you have
> forwarded it on. For forms sake and per the DCO an S-o-b should probably
> be added.

I've reviewed it.

It's signed-off-by Zheng; he's the sole author so I didn't think S-o-b
from me would make sense.

I'm adding Zheng to this email's CC list though.

> > +   (* It's upt to the mkdir logic to decide what to do with existing path 
> > *)
> typo. I can fix on commit, assuming I remember.
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.