[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] Call sched_destroy_domain before cpupool_rm_domain.

  • To: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Mon, 04 Nov 2013 10:58:20 +0100
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • Delivery-date: Mon, 04 Nov 2013 09:59:02 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Message-ID:Date:From:Organization:User-Agent: MIME-Version:To:CC:Subject:References:In-Reply-To: Content-Type:Content-Transfer-Encoding; b=BZVH28D91URaJM4xxqSuxL8Nffq4TImhG3VjNkvCwbQzeqaicWqWbML6 N/cwrsYl+Uh4bxctv8OwhheBlboloJt6zeQDbd9vQKhlKWvCnv4tRoESt TZ4j3ZkbIOGcpoCLa4QJ/ofjanEB/O7ZqKksywV2nh+v1sQW5QIYOosoZ DCJ3Z5nu67sGOAe+rtzpCTTqA5DGL5xFHzYorpofSnebB9QbBVPRVls41 swMQAccfGDDO8/G0NHNTyjsd4ff/O;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 04.11.2013 10:26, Dario Faggioli wrote:
On lun, 2013-11-04 at 07:30 +0100, Juergen Gross wrote:
On 04.11.2013 04:03, Nathan Studer wrote:
From: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>

The domain destruction code, removes a domain from its cpupool
before attempting to destroy its scheduler information.  Since
the scheduler framework uses the domain's cpupool information
to decide on which scheduler ops to use, this results in the
the wrong scheduler's destroy domain function being called
when the cpupool scheduler and the initial scheduler are

Correct this by destroying the domain's scheduling information
before removing it from the pool.

Signed-off-by: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>

Reviewed-by: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>

I think this is a candidate for backports too, isn't it?

Nathan, what was happening without this patch? Are you able to quickly
figure out what previous Xen versions suffers from the same bug?

In theory this bug is present since 4.1.

OTOH it will be hit only with arinc653 scheduler in a cpupool other than
Pool-0. And I don't see how this is being supported by arinc653 today (pick_cpu
will always return 0).

All other schedulers will just call xfree() for the domain specific data (and
may be update some statistic data, which is not critical).


Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 62060 2932
Fujitsu                                   e-mail: juergen.gross@xxxxxxxxxxxxxx
Mies-van-der-Rohe-Str. 8                Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.