Re: [Xen-devel] [RFC PATCH 00/11] tmem: some basic cleanup

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Nov 04, 2013 at 03:56:22PM +0000, Jan Beulich wrote:
> >>> On 04.11.13 at 13:40, Bob Liu <lliubbo@xxxxxxxxx> wrote:
> > There are too many typedefs and referenced once functions in tmem, perhaps 
> > the
> > reason was tmem was designed can be ported to other hypersivor easily.
> > But when I try to read tmem source code, some of them are not very
> > straightforward. This patchset try to clean up them. It's only my thoughts 
> > so I
> > tag this patchset with RFC.
> 
> If I was the maintainer, or as to make a recommendation, I wouldn't
> accept these changes - they were done for a purpose after all. If

The purpose for this was done so that if anybody wanted to lift the
tmem code out of the hypervisor the "hypervisor-specific" parts would
have to be implemented. While the generic ones could be easily
copied over. Hence also the two files implementation.

But that is not really neccessary nowadays - and the code could
all be nicely merged in one file.

> anything a re-work from grounds up would seem the only reasonable
> option.

I am really in favour of the KISS principle and incremental
cleanups/fixes is what I am most comfortable with.

That is as long as each patch has only _one_ logical change. The
same way it is done in the Linux world.

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel