[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 00/11] tmem: some basic cleanup

On 11/04/2013 11:56 PM, Jan Beulich wrote:
>>>> On 04.11.13 at 13:40, Bob Liu <lliubbo@xxxxxxxxx> wrote:
>> There are too many typedefs and referenced once functions in tmem, perhaps 
>> the
>> reason was tmem was designed can be ported to other hypersivor easily.
>> But when I try to read tmem source code, some of them are not very
>> straightforward. This patchset try to clean up them. It's only my thoughts 
>> so I
>> tag this patchset with RFC.
> If I was the maintainer, or as to make a recommendation, I wouldn't
> accept these changes - they were done for a purpose after all. If
> anything a re-work from grounds up would seem the only reasonable
> option.

Well, I'd like re-work tmem from ground also.
But currently it's too difficult for me to re-work it since I don't have
enough knowledge. It's hard for me to understand tmem quickly because of
its order of complexity and I'm not fit to its coding style.

Clean up patches will also be the first step even reworking it from
grounds unless we can start with a new better/simpler tmem.c
implementation and replace current one directly.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.