Re: [Xen-devel] [RFC 7/8] x86/hpet: debug keyhandlers

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/11/13 11:11, Jan Beulich wrote:
>>>> On 04.11.13 at 19:54, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> @@ -879,6 +896,8 @@ u64 __init hpet_setup(void)
>>      hpet_rate = 1000000000000000ULL; /* 10^15 */
>>      (void)do_div(hpet_rate, hpet_period);
>>  
>> +    register_keyhandler('1', &hpet_dump_state);
> I'd prefer the numbers to be left alone if at all possible. How
> about 'E'?
>
> Jan
>

I wasn't intending for this keyhandler to be committed, at least
certainly not taking the place of '1'  (As people might be able to guess
from similar debugging patches of mine, I regularly have many of the
numbers in use for temporary keyhandlers)

While it was very useful while working on this issue, I don't think it
would be particularly useful in general, especially given the increasing
scarcity of keys.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel