[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/3] get_maintainer.pl: Adjust to review comments

On 11/05/13 09:19, Ian Campbell wrote:
On Tue, 2013-11-05 at 09:11 -0500, Don Slutz wrote:
From: Don Slutz <dslutz@xxxxxxxxxxx>
Please can you list the specific changes for the changelog. No need to
resend, I'll fold the list into the commit message.
Not sure how much you want.

Here is the long versions (Includeing the change fro reference):

-my $email_git_fallback = 1;
+my $email_git_fallback = 0;

Date:ÂÂÂÂ Fri, 4 Oct 2013 19:03:44 +1300
From:ÂÂÂÂ Matthew Daley <mattjd@xxxxxxxxx>

This script was discussed in the recent past (
http://lists.xen.org/archives/html/xen-devel/2013-03/msg00984.html )
and IIUC the consensus was that, if it were to go in, the Git fallback
searches would be disabled ($email_git_fallback = 0, AFAIK). IMO It's
not necessary for a (relative to Linux) small project like Xen, with
adequate MAINTAINERS coverage, to need this fallback.

-my $output_rolestats = 1;
+my $output_rolestats = 0;

Date:ÂÂÂÂ Fri, 4 Oct 2013 20:25:51 +1300
From:ÂÂÂÂ Matthew Daley <mattjd@xxxxxxxxx>

Also, I think I needed to set $output_rolestats = 0 to get sensible
output (without the unnecessary role stuff).

+my $email_drop_the_rest_supporter_if_supporter_found = 1;
+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ 'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found,

@@ -651,6 +653,19 @@ sub get_maintainers {
+    if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) {
+        my @email_new;
+        my $do_replace = 0;
+        foreach my $email (@email_to) {
+            if ($email->[1] ne 'supporter:THE REST') {
+                $do_replace = 1;
+                push @email_new, $email;
+            }
+        }
+        @email_to = @email_new
+            if $do_replace;
+    }

Date:ÂÂÂÂ Fri, 4 Oct 2013 19:03:44 +1300
From:ÂÂÂÂ Matthew Daley <mattjd@xxxxxxxxx>

Also, speaking of adequate MAINTAINERS coverage, the last entry which
attempts to have Keir as a fallback for "everything else" actually
mean Keir is CC'd on everything using the script. This is because it
uses all matching regexes and not just the most specific. Perhaps this
entry needs to be commented out (leaving it their for manual
inspection), or removed entirely?

Date:ÂÂÂÂ Fri, 4 Oct 2013 10:35:19 +0100
From:ÂÂÂÂ Jan Beulich <JBeulich@xxxxxxxx>

Or the script be made more intelligent? After all, the entry is there
for a reason...

Just to confirm: This doesn't suppress any xen-devel@ CC, which should
always be there, does it?
Nope. It only drops the e-mail (currently Keir Fraser) for "supporter:THE REST" role when any other role is found. Also you can turn it off with --nodrop_the_rest_supporter

don-760:~/xen>scripts/get_maintainer.pl --nodrop_the_rest_supporter config_v2/0001-.config-Allow-all-URL-s-to-be-specified-in-.config.patch
Keir Fraser <keir@xxxxxxx>
Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Ian Campbell <ian.campbell@xxxxxxxxxx>

don-760:~/xen>scripts/get_maintainer.pl config_v2/0001-.config-Allow-all-URL-s-to-be-specified-in-.config.patch
Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Ian Campbell <ian.campbell@xxxxxxxxxx>

   -Don Slutz

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.