Re: [Xen-devel] [PATCH 03/15] xen: numa-sched: leave node-affinity alone if not in "auto" mode

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 11/05/2013 02:37 PM, Jan Beulich wrote:
> > > > On 05.11.13 at 15:21, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > On 10/03/2013 06:45 PM, Dario Faggioli wrote:
> > > If the domain's NUMA node-affinity is being specified by the
> > > user/toolstack (instead of being automatically computed by Xen),
> > > we really should stick to that. This means domain_update_node_affinity()
> > > is wrong when it filters out some stuff from there even in "!auto"
> > > mode.
> > >
> > > This commit fixes that. Of course, this does not mean node-affinity
> > > is always honoured (e.g., a vcpu won't run on a pcpu of a different
> > > cpupool) but the necessary logic for taking into account all the
> > > possible situations lives in the scheduler code, where it belongs.
> > >
> > > What could happen without this change is that, under certain
> > > circumstances, the node-affinity of a domain may change when the
> > > user modifies the vcpu-affinity of the domain's vcpus. This, even
> > > if probably not a real bug, is at least something the user does
> > > not expect, so let's avoid it.
> > >
> > > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > > ---
> > > This has been submitted already as a single patch on its own.
> > > Since this series needs the change done here, just include it
> > > in here, instead of pinging the original submission and deferring
> > > posting this series.
> > Kier / Jan: And as this is actually independent of the rest of the
> > series, and already has my reviewed-by, it can be applied right now
> > without waiting for the rest of the series to be reviewed.
> Right. It needs Keir's ack in any case.
>
> But then again this was patch 3 in a series posted over a month
> ago (and being a mishmash of hypervisor and tools patches), so
> I would have
> - considered it stale by now, expecting a re-submission
> - expected to be told that it can be applied on its own
Yes, that's what I was doing. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel