Re: [Xen-devel] [PATCH v2 05/12] xenctx: Change print_symbol to do the space before.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.11.13 at 21:08, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
> From: Don Slutz <Don@xxxxxxxxxxxxxxx>
> 
> This stops the output of an extra space at the end of the line.
> 
> Signed-off-by: Don Slutz <Don@xxxxxxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
>  tools/xentrace/xenctx.c |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> index a20281e..5e2354c 100644
> --- a/tools/xentrace/xenctx.c
> +++ b/tools/xentrace/xenctx.c
> @@ -158,9 +158,9 @@ static void print_symbol(guest_word_t addr)
>          return;
>  
>      if (addr==s->address)
> -        printf("%s ", s->name);
> +        printf(" %s", s->name);
>      else
> -        printf("%s+%#x ", s->name, (unsigned int)(addr - s->address));
> +        printf(" %s+%#x", s->name, (unsigned int)(addr - s->address));
>  }
>  
>  static void read_symbol_table(const char *symtab)
> @@ -287,7 +287,7 @@ static void print_ctx_32(vcpu_guest_context_x86_32_t 
> *ctx)
>  {
>      struct cpu_user_regs_x86_32 *regs = &ctx->user_regs;
>  
> -    printf("cs:eip: %04x:%08x ", regs->cs, regs->eip);
> +    printf("cs:eip: %04x:%08x", regs->cs, regs->eip);
>      print_symbol(regs->eip);
>      print_flags(regs->eflags);
>      printf("ss:esp: %04x:%08x\n", regs->ss, regs->esp);
> @@ -316,7 +316,7 @@ static void print_ctx_32on64(vcpu_guest_context_x86_64_t 
> *ctx)
>  {
>      struct cpu_user_regs_x86_64 *regs = &ctx->user_regs;
>  
> -    printf("cs:eip: %04x:%08x ", regs->cs, (uint32_t)regs->eip);
> +    printf("cs:eip: %04x:%08x", regs->cs, (uint32_t)regs->eip);
>      print_symbol((uint32_t)regs->eip);
>      print_flags((uint32_t)regs->eflags);
>      printf("ss:esp: %04x:%08x\n", regs->ss, (uint32_t)regs->esp);
> @@ -345,7 +345,7 @@ static void print_ctx_64(vcpu_guest_context_x86_64_t 
> *ctx)
>  {
>      struct cpu_user_regs_x86_64 *regs = &ctx->user_regs;
>  
> -    printf("rip: %016"PRIx64" ", regs->rip);
> +    printf("rip: %016"PRIx64, regs->rip);
>      print_symbol(regs->rip);
>      print_flags(regs->rflags);
>      printf("rsp: %016"PRIx64"\n", regs->rsp);
> @@ -443,7 +443,7 @@ static void print_ctx_32(vcpu_guest_context_t *ctx)
>  {
>      vcpu_guest_core_regs_t *regs = &ctx->user_regs;
>  
> -    printf("PC:       %08"PRIx32" ", regs->pc32);
> +    printf("PC:       %08"PRIx32, regs->pc32);
>      print_symbol(regs->pc32);
>      printf("\n");
>      printf("CPSR:     %08"PRIx32"\n", regs->cpsr);
> @@ -495,7 +495,7 @@ static void print_ctx_64(vcpu_guest_context_t *ctx)
>  {
>      vcpu_guest_core_regs_t *regs = &ctx->user_regs;
>  
> -    printf("PC:       %016"PRIx64" ", regs->pc64);
> +    printf("PC:       %016"PRIx64, regs->pc64);
>      print_symbol(regs->pc64);
>      printf("\n");
>  
> @@ -702,7 +702,7 @@ static int print_stack(vcpu_guest_context_any_t *ctx, int 
> vcpu, int width)
>          printf("Call Trace:\n");
>      printf("%c [<", xenctx.stack_trace ? '*' : ' ');
>      print_stack_word(instr_pointer(ctx), width);
> -    printf(">] ");
> +    printf(">]");
>  
>      print_symbol(instr_pointer(ctx));
>      printf(" <--\n");
> @@ -742,7 +742,7 @@ static int print_stack(vcpu_guest_context_any_t *ctx, int 
> vcpu, int width)
>                  word = read_stack_word(p, width);
>                  printf("%c [<", xenctx.stack_trace ? '|' : ' ');
>                  print_stack_word(word, width);
> -                printf(">] ");
> +                printf(">]");
>                  print_symbol(word);
>                  printf("\n");
>                  stack += width;
> @@ -758,7 +758,7 @@ static int print_stack(vcpu_guest_context_any_t *ctx, int 
> vcpu, int width)
>              if (is_kernel_text(word)) {
>                  printf("  [<");
>                  print_stack_word(word, width);
> -                printf(">] ");
> +                printf(">]");
>                  print_symbol(word);
>                  printf("\n");
>              } else if (xenctx.stack_trace) {
> -- 
> 1.7.1



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel