Re: [Xen-devel] [PATCH v2 04/12] xenctx: Add stack address to dump, switch to 16 bytes per line.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.11.13 at 21:08, Don Slutz <dslutz@xxxxxxxxxxx> wrote:

Again - why? This makes it just two entries per line for a 64-bit
guest. Pretty little I would say.

Jan

> From: Don Slutz <Don@xxxxxxxxxxxxxxx>
> 
> Signed-off-by: Don Slutz <Don@xxxxxxxxxxxxxxx>
> ---
>  tools/xentrace/xenctx.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> index dabce16..a20281e 100644
> --- a/tools/xentrace/xenctx.c
> +++ b/tools/xentrace/xenctx.c
> @@ -640,7 +640,7 @@ static int print_code(vcpu_guest_context_any_t *ctx, int 
> vcpu)
>      return 0;
>  }
>  
> -#define BYTES_PER_LINE 32
> +#define BYTES_PER_LINE 16
>  
>  static int print_stack(vcpu_guest_context_any_t *ctx, int vcpu, int width)
>  {
> @@ -663,6 +663,8 @@ static int print_stack(vcpu_guest_context_any_t *ctx, int 
> vcpu, int width)
>          int j = 0;
>          int k;
>  
> +        print_stack_word(stack, width);
> +        printf(":");
>          while(stack < stack_limit && stack < stack_pointer(ctx) + 
> i*BYTES_PER_LINE) {
>              p = map_page(ctx, vcpu, stack);
>              if (!p)
> -- 
> 1.7.1




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel