Re: [Xen-devel] [PATCH v2 04/12] xenctx: Add stack address to dump, switch to 16 bytes per line.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-11-07 at 08:12 +0000, Jan Beulich wrote:
> >>> On 06.11.13 at 21:08, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
> 
> Again - why?

Having the stack address there can make it easier to locate a word
referenced by a register for example, without error prone counting. In
general many of the changelogs in this series could do with a second
sentence in them after the title giving some rationale so we don't have
to guess.

>  This makes it just two entries per line for a 64-bit
> guest. Pretty little I would say.

Agreed.

I expect that along with the previous patch lines would now be over 80
columns for sure. If that's the case then either the ascii or the
address (or both) needs to be optional IMHO.

> 
> Jan
> 
> > From: Don Slutz <Don@xxxxxxxxxxxxxxx>
> > 
> > Signed-off-by: Don Slutz <Don@xxxxxxxxxxxxxxx>
> > ---
> >  tools/xentrace/xenctx.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> > index dabce16..a20281e 100644
> > --- a/tools/xentrace/xenctx.c
> > +++ b/tools/xentrace/xenctx.c
> > @@ -640,7 +640,7 @@ static int print_code(vcpu_guest_context_any_t *ctx, 
> > int 
> > vcpu)
> >      return 0;
> >  }
> >  
> > -#define BYTES_PER_LINE 32
> > +#define BYTES_PER_LINE 16
> >  
> >  static int print_stack(vcpu_guest_context_any_t *ctx, int vcpu, int width)
> >  {
> > @@ -663,6 +663,8 @@ static int print_stack(vcpu_guest_context_any_t *ctx, 
> > int 
> > vcpu, int width)
> >          int j = 0;
> >          int k;
> >  
> > +        print_stack_word(stack, width);
> > +        printf(":");
> >          while(stack < stack_limit && stack < stack_pointer(ctx) + 
> > i*BYTES_PER_LINE) {
> >              p = map_page(ctx, vcpu, stack);
> >              if (!p)
> > -- 
> > 1.7.1
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel