[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 04/12] xenctx: Add stack address to dump, switch to 16 bytes per line.

On 11/07/13 07:46, Ian Campbell wrote:
On Thu, 2013-11-07 at 08:12 +0000, Jan Beulich wrote:
On 06.11.13 at 21:08, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
Again - why?
Having the stack address there can make it easier to locate a word
referenced by a register for example, without error prone counting. In
general many of the changelogs in this series could do with a second
sentence in them after the title giving some rationale so we don't have
to guess.

  This makes it just two entries per line for a 64-bit
guest. Pretty little I would say.

I expect that along with the previous patch lines would now be over 80
columns for sure. If that's the case then either the ascii or the
address (or both) needs to be optional IMHO.


I am happy to make it a command line option.
   -Don Slutz

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.