[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 08/12] xenctx: Add -d <daddr> option to dump memory at daddr as a stack.

On 11/07/13 03:22, Jan Beulich wrote:
On 06.11.13 at 21:08, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
@@ -956,9 +973,9 @@ int main(int argc, char **argv)
if (xenctx.all_vcpus)
-        dump_all_vcpus();
+        dump_all_vcpus(stk_addr);
-        dump_ctx(vcpu);
+        dump_ctx(vcpu, stk_addr);
For one, it hardly makes much sense to dump all vCPU-s with a
single stack address. And assuming a stack can't sit at address
zero is wrong too - you shouldn't make any assumptions in
particular for HVM guests.

So what you intend here should lead to just the requested
"stack" to be printed, without touching other functionality (i.e.
likely you'll want the "if()" above preceded by another one, and
itself converted to an "else if()").


It is clear that handling "-d" out side of dump_ctx() make sense. Not so sure 
on the simple else.  I think that -C should still dump all cpus even if -d is provided.  
I guess I could complain if both -d and -C are specified, but I like to just do the 
requested actions.
   -Don Slutz

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.