[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RESEND 10/12] libxl: numa-sched: enable getting/specifying per-vcpu node-affinity

On gio, 2013-11-07 at 18:29 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH RESEND 10/12] libxl: numa-sched: enable 
> getting/specifying per-vcpu node-affinity"):
> > by providing the proper get/set interfaces and wiring them
> > to the new libxc calls from the previous commit.
> > 
> > For the 'get' part, the node-affinity of all the vcpus of a
> > domain is also reported via libxl_list_vcpu() (exactly as it
> > is happening for their vcpu affinity already), adding a
> > specific field to libxl_vcpuinfo.
> This is a change to the libxl ABI.  I think you should bump the MAJOR
> number in this patch (or a previous one).
Oh, do I? I may be missing something then. Every time I've done
something similar to this before, I did provide the proper LIBXL_HAVE_*
stuff (which this patch does), for the sake of _API_ compatibility, and
that was it. :-(

I've just looked up in libxl.h and found the comment block about ABI
compatibility and SONAME bumping but (sorry) I'm not 100% sure I fully
understand what it says. Does it (and you) mean that, since this is the
first change since 4.3 that breaks ABI compatibility, I should include a
patch to tools/libxl/Makefile doing something like:



If yes, anything more than that?

Thanks and Regards,

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.