Re: [Xen-devel] [PATCH RESEND 10/12] libxl: numa-sched: enable getting/specifying per-vcpu node-affinity

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("Re: [PATCH RESEND 10/12] libxl: numa-sched: enable 
getting/specifying per-vcpu node-affinity"):
> On gio, 2013-11-07 at 18:29 +0000, Ian Jackson wrote:
> > This is a change to the libxl ABI.  I think you should bump the MAJOR
> > number in this patch (or a previous one).
> > 
> Oh, do I? I may be missing something then. Every time I've done
> something similar to this before, I did provide the proper LIBXL_HAVE_*
> stuff (which this patch does), for the sake of _API_ compatibility, and
> that was it. :-(

Yes.  Probably in the past this bump had already been done for some
other reason.

> I've just looked up in libxl.h and found the comment block about ABI
> compatibility and SONAME bumping but (sorry) I'm not 100% sure I fully
> understand what it says. Does it (and you) mean that, since this is the
> first change since 4.3 that breaks ABI compatibility, I should include a
> patch to tools/libxl/Makefile doing something like:
> 
> -MAJOR=4.3
> +MAJOR=4.4
> 
> ?

Exactly.

> If yes, anything more than that?

No, nothing more.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel