Re: [Xen-devel] [PATCH 1 of 1] Update ZFS sources from illumos.org:

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-10-31 at 23:04 +0400, Igor Kozhkuhov wrote:
> https://github.com/illumos/illumos-gate/tree/master/usr/src/grub/grub-0.97/stage2

Is this link to a specific unchanging version? It looks to me like it
probably changes everytime something is committed.

> Additional CFLAGS rules have been added after 'CFLAGS += -Werror 
> -D_GNU_SOURCE' in Rules.mk

Actually, they've been added to tools/libfsimage/zfs/Makefile ?

> Signed-off-by: Igor Kozhukhov <ikozhukhov@xxxxxxxxx>
> Asked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

This isn't one of our standard tags, I take it you didn't mean Acked-by,
since I didn't ack it. I think all I did was ask for submitting patches
to be followed etc, no need to credit me for that IMHO.

> 
> diff -r 7c12aaa128e3 -r 7afe0b19c898 tools/libfsimage/zfs/Makefile
> --- a/tools/libfsimage/zfs/Makefile   Thu Oct 24 22:46:20 2013 +0100
> +++ b/tools/libfsimage/zfs/Makefile   Thu Oct 31 22:48:42 2013 +0400
> @@ -25,7 +25,7 @@
>  XEN_ROOT = $(CURDIR)/../../..
>  
>  CFLAGS += -DFSYS_ZFS -DFSIMAGE -I$(XEN_ROOT)/tools/libfsimage/zfs
> -LIB_SRCS-y = zfs_lzjb.c zfs_sha256.c zfs_fletcher.c fsi_zfs.c fsys_zfs.c
> +LIB_SRCS-y = zfs_lzjb.c zfs_sha256.c zfs_fletcher.c fsi_zfs.c fsys_zfs.c 
> zfs_lz4.c
>  
>  FS = zfs
>  
> @@ -36,3 +36,8 @@ all: fs-all
>  install: fs-install
>  
>  include $(XEN_ROOT)/tools/libfsimage/Rules.mk
> +
> +# need for build illumos ZFS
> +CFLAGS += -Wno-parentheses
> +CFLAGS += -Wno-unused

Are these really needed right at the end like this rather than in the
same paragraph as the CFLAGS stuff in the context of the previous hunk?

> +# end
> diff -r 7c12aaa128e3 -r 7afe0b19c898 tools/libfsimage/zfs/fsi_zfs.h
> --- a/tools/libfsimage/zfs/fsi_zfs.h  Thu Oct 24 22:46:20 2013 +0100
> +++ b/tools/libfsimage/zfs/fsi_zfs.h  Thu Oct 31 22:48:42 2013 +0400
> @@ -36,6 +36,8 @@
>  [...]

I'm not in much position to comment on the actual code.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel