[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1 of 1] Update ZFS sources from illumos.org:

On Mon, 2013-11-11 at 20:57 +0400, Igor Kozhukhov wrote:
> On Nov 11, 2013, at 8:23 PM, Ian Campbell wrote:
> > On Thu, 2013-10-31 at 23:04 +0400, Igor Kozhkuhov wrote:
> >> https://github.com/illumos/illumos-gate/tree/master/usr/src/grub/grub-0.97/stage2
> > 
> > Is this link to a specific unchanging version? It looks to me like it
> > probably changes everytime something is committed.
> This link specified where i got sources for libfsimage ZFS updates.

It's not a static copy of the source though. Someone can't use this link
in a years time to go and compare what has changed since this sync
because it will have changed.

There needs to be a changeset ID corresponding to the exact source you
imported in there somewhere, either in the URL or in a comment.

> > 
> >> Additional CFLAGS rules have been added after 'CFLAGS += -Werror 
> >> -D_GNU_SOURCE' in Rules.mk
> > 
> > Actually, they've been added to tools/libfsimage/zfs/Makefile ?
> > 
> Rules.mk contain 'CFLAGS += -Werror -D_GNU_SOURCE'
> this file included to zfs/Makefile on bottom. if we have to add additional 
> rules for disable GCC warnings we should to add our rules after -Werror.

Why must they be after -Werror?

> I have added additional rules for ZFS compilations after including Rules.mk 
> in zfs/Makefile
> >> Signed-off-by: Igor Kozhukhov <ikozhukhov@xxxxxxxxx>
> >> Asked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> > 
> > This isn't one of our standard tags, I take it you didn't mean Acked-by,
> > since I didn't ack it. I think all I did was ask for submitting patches
> > to be followed etc, no need to credit me for that IMHO.
> > 
> Sorry for this - my misunderstanding of process.

No problem.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.