Re: [Xen-devel] [PATCH 1 of 1] Update ZFS sources from illumos.org:

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

(please don't top post)

On Mon, 2013-11-11 at 21:16 +0400, Igor Kozhukhov wrote:
> Hi Ian,
> 
> we can use:
> https://github.com/illumos/illumos-gate/tree/master/usr/src/grub@2acef22db7808606888f8f92715629ff3ba555b9
> 
> will it be correct ?
> change set after '@'

That link is 404 for me.

> about -Werror
> 
> by GCC specific, if we want to disable some warnings we should add rules 
> after -Werror.
> example:
> -Werror -Wno-parentheses -Wno-unused
> 
> if we add rules "-Wno-parentheses -Wno-unused" before "-Werror" - they will 
> be ignored and we will have build problem.

Are you sure? We have at least some instances of this in our tree
already and it doesn't seem to be having any adverse impact.

The Werror docs don't say anything about this requirement, just "Make
all warnings into errors.". Since Werror doesn't actually enable or
disable any warnings itself I can't see why the ordering would matter.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel