Re: [Xen-devel] [V1 PATCH 04/11] PVH dom0: create update_memory_mapping() function

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.13 at 02:23, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> Note, iomem_access_permitted can't be moved to the function
> because current doesn't point to dom0 in construct_dom0.

And it would be rather pointless to try to check this. For Dom0 you
just need to make sure you don't call the function for inappropriate
ranges.

> +static long update_memory_mapping(struct domain *d, unsigned long gfn,

Is there any code path really returning something that doesn't
fit in an int?

> +                           unsigned long mfn, unsigned long nr_mfns,
> +                           bool_t add)
> +{
> +    unsigned long i;
> +    long ret;

Same question here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel