Re: [Xen-devel] [V1 PATCH 04/11] PVH dom0: create update_memory_mapping() function

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Tue, 12 Nov 2013 16:12:13 +0000
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 09.11.13 at 02:23, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > Note, iomem_access_permitted can't be moved to the function
> > because current doesn't point to dom0 in construct_dom0.
> 
> And it would be rather pointless to try to check this. For Dom0 you
> just need to make sure you don't call the function for inappropriate
> ranges.
> 
> > +static long update_memory_mapping(struct domain *d, unsigned long
> > gfn,
> 
> Is there any code path really returning something that doesn't
> fit in an int?

Well, the caller arch_do_domctl() returns long and has it declared
long too. Want me to change it to int and it will implicitly get cast'd?

long arch_do_domctl(
    struct xen_domctl *domctl, struct domain *d,
    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
{
    long ret = 0;

>> +                           unsigned long mfn, unsigned long nr_mfns,
>> +                           bool_t add)
>> +{
>> +    unsigned long i;
>> +    long ret;  

>Same question here.

Original code has loop count as ulong, prob because nr_mfns is long.

    case XEN_DOMCTL_memory_mapping:
    {
        unsigned long gfn = domctl->u.memory_mapping.first_gfn;
        ..
        unsigned long i;

Want me to change it to int also?

thanks
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel