Re: [Xen-devel] [PATCH v4 17/17] libxl: Coding Style cleanups to libxl_dom.c

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH v4 17/17] libxl: Coding Style cleanups to 
libxl_dom.c"):
> This file had a rash of spaces and assignments inside if expressions.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

If I were doing this

> -        if ( ret != 0) {
> +        if (ret != 0) {

I would write simply

  +        if (ret) {

but I know not everyone agrees.

Thanks,

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel