Re: [Xen-devel] [PATCH v4 17/17] libxl: Coding Style cleanups to libxl_dom.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-12 at 18:08 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH v4 17/17] libxl: Coding Style cleanups to 
> libxl_dom.c"):
> > This file had a rash of spaces and assignments inside if expressions.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks.

> 
> If I were doing this
> 
> > -        if ( ret != 0) {
> > +        if (ret != 0) {
> 
> I would write simply
> 
>   +        if (ret) {
> 
> but I know not everyone agrees.

I thought about changing this too but decided not to keep pulling on the
thread...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel