[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 16/17] libxl: build a device tree for ARM guests

On Tue, 2013-11-12 at 18:06 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH v4 16/17] libxl: build a device tree for ARM 
> guests"):
> > Uses xc_dom_devicetree_mem which was just added. The call to this needs to 
> > be
> > carefully sequenced to be after xc_dom_parse_image (so we can tell which 
> > kind
> > of guest we are building, although we don't use this yet) and before
> > xc_dom_mem_init which tries to decide where to place the FDT in guest RAM.
> > 
> > Removes libxl_noarch which would only have been used by IA64 after this
> > change. Remove IA64 as part of this patch.
> > 
> > There is no attempt to expose this as a configuration setting for the user.
> > 
> > Includes a debug hook to dump the dtb to a file for inspection.
> ...
> The debug dump function has an anomalous error handling style[1] and
> still leaks fd under some conditions.

Oh balls, I thought about all this but neglected to do the actual

> (Sorry to find problems only in an unimportant debug function...)

No worries, you had already raised them and I should have done something
about it...

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.