[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/7] xen: vNUMA support for guests.

On 11/14/2013 11:18 AM, Dario Faggioli wrote:
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index a057069..bc61bab 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -89,4 +89,14 @@ extern unsigned int xen_processor_pmbits;

  extern bool_t opt_dom0_vcpus_pin;

+struct domain_vnuma_info {
+    uint nr_vnodes;
+    uint *vdistance;
+    uint *vcpu_to_vnode;
+    uint *vnode_numamap;
+    struct vmemrange *vmemrange;
I think you can kill the 'domain_' prefix. It's pretty clear this is a
per-domain thing, from the fact that it lives inside struct domain.

Still, it doesn't hurt to have a little bit of extra context. If you look above in this file, for example, it has "vcpu_guest_context" -- even though it should be obvious that guest context is per-vcpu. :-)

+void domain_vnuma_destroy(struct domain_vnuma_info *v);
Why do you need to declare this function here? Isn't this used only in
domain.c ?

In fact, it should probably be static.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.