Re: [Xen-devel] [PATCH v2 1/7] xen: vNUMA support for guests.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.11.13 at 12:18, Dario Faggioli <dario.faggioli@xxxxxxxxxx> wrote:
> On mer, 2013-11-13 at 22:26 -0500, Elena Ufimtseva wrote:
>> @@ -1297,6 +1298,15 @@ int continue_hypercall_on_cpu(
>>      return 0;
>>  }
>>  
>> +void domain_vnuma_destroy(struct domain_vnuma_info *v)
>> +{
> I think vnuma_destroy() is ok, as it is tmem_destroy(),
> evtchn_destory(), etc.

And the parameter would be very nice to be named other than
"v" (which we commonly use for struct vcpu * instances - in fact
I got misled to think you would be freeing per-vCPU information
here...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel