Re: [Xen-devel] [V1 PATCH 03/11] PVH dom0: iommu related changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.11.13 at 02:43, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Tue, 12 Nov 2013 16:08:51 +0000
> "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> >>> On 09.11.13 at 02:23, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>> >>> wrote:
>> > --- a/xen/drivers/passthrough/iommu.c
>> > +++ b/xen/drivers/passthrough/iommu.c
>> > @@ -125,15 +125,27 @@ int iommu_domain_init(struct domain *d)
>> >      return hd->platform_ops->init(d);
>> >  }
>> >  
>> > +static inline void check_dom0_pvh_reqs(struct domain *d)
>> 
>> No point for this to be an inline function. Even more, irrespective
>> of whether it is, it should also be marked __init.
> 
> Ok, marked __init, removed inline. Or did you mean get
> rid of the function and move checks to iommu_dom0_init()?

I would have preferred so, but I'm fine with what you did.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel