Re: [Xen-devel] [PATCH 7 of 7 V4] tools/libxl: refactor domain_suspend_callback code to be fully asynchronous

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Mon, Nov 18, 2013 at 11:49 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Shriram Rajagopalan writes ("[PATCH 7 of 7 V4] tools/libxl: refactor 
> domain_suspend_callback code to be fully asynchronous"):
>> tools/libxl: refactor domain_suspend_callback code to be fully asynchronous
>>
>> libxl__domain_suspend_callback_common uses usleep calls,
>> while the caller libxl_domain_suspend_callback is asynchronous.
>> This patch refactors the libxl__domain_suspend__common code to use
>> AO facilities like libxl event loop timers instead of usleep calls.
>
> Thanks.  This mixture of code motion, semantic changes, and changes
> to function boundaries, is very difficult to review.
>
> Do you think you can split this patch up into a small subseries
> somehow ?  For example by adding pre-patches or post-patches (or both)
> containing the code motion, and separate patches with functional
> change but no bulk motion ?
>

Yep sure.

> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel