Re: [Xen-devel] [PATCH] xen/arm: gic: don't use dom0 variable in gicv_setup

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-19 at 17:55 +0000, Julien Grall wrote:
> The commit 99bf30a "xen: arm: define guest virtual platform in API headers"
> modifies gicv_setup to either use harcoded addresses for guest or hardware
> addresses for dom0. In the latter case, the variable dom0 is not yet
> initialized. dom0 receives assignment by the return of domain_create which
> calls gicv_setup.
> Use the ID to know whether the domain is dom0 or not.

Oops, I missed this because the platform I was testing (fastmodel ==
vexpress) happens to have the same GIC addresses as the virtual
platform.

> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked + applied.

I investigated is_hardware_domain and friends but they relies on
d->is_privileged which is also not yet set.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel